[ https://issues.apache.org/jira/browse/HADOOP-12321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742607#comment-14742607 ]
Hadoop QA commented on HADOOP-12321: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 24m 46s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 59s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 1s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 4m 17s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 37s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 2m 13s | Post-patch findbugs hadoop-hdfs-project/hadoop-hdfs compilation is broken. | | {color:red}-1{color} | findbugs | 2m 34s | Post-patch findbugs hadoop-hdfs-project/hadoop-hdfs-nfs compilation is broken. | | {color:red}-1{color} | findbugs | 2m 54s | Post-patch findbugs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs compilation is broken. | | {color:red}-1{color} | findbugs | 3m 14s | Post-patch findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice compilation is broken. | | {color:red}-1{color} | findbugs | 3m 34s | Post-patch findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager compilation is broken. | | {color:red}-1{color} | findbugs | 3m 54s | Post-patch findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager compilation is broken. | | {color:red}-1{color} | findbugs | 4m 15s | Post-patch findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy compilation is broken. | | {color:green}+1{color} | findbugs | 4m 15s | The patch does not introduce any new Findbugs (version ) warnings. | | {color:red}-1{color} | common tests | 0m 20s | Tests failed in hadoop-common. | | {color:red}-1{color} | mapreduce tests | 0m 13s | Tests failed in hadoop-mapreduce-client-hs. | | {color:red}-1{color} | yarn tests | 0m 15s | Tests failed in hadoop-yarn-server-applicationhistoryservice. | | {color:red}-1{color} | yarn tests | 0m 15s | Tests failed in hadoop-yarn-server-nodemanager. | | {color:red}-1{color} | yarn tests | 0m 19s | Tests failed in hadoop-yarn-server-resourcemanager. | | {color:red}-1{color} | yarn tests | 0m 11s | Tests failed in hadoop-yarn-server-web-proxy. | | {color:red}-1{color} | hdfs tests | 0m 20s | Tests failed in hadoop-hdfs. | | {color:red}-1{color} | hdfs tests | 0m 12s | Tests failed in hadoop-hdfs-nfs. | | | | 56m 2s | | \\ \\ || Reason || Tests || | Failed build | hadoop-common | | | hadoop-mapreduce-client-hs | | | hadoop-yarn-server-applicationhistoryservice | | | hadoop-yarn-server-nodemanager | | | hadoop-yarn-server-resourcemanager | | | hadoop-yarn-server-web-proxy | | | hadoop-hdfs | | | hadoop-hdfs-nfs | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12755617/HADOOP-12321-003.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 7269906 | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-common.txt | | hadoop-mapreduce-client-hs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt | | hadoop-yarn-server-applicationhistoryservice test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | hadoop-yarn-server-web-proxy test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-hdfs.txt | | hadoop-hdfs-nfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7655/console | This message was automatically generated. > Make JvmPauseMonitor to AbstractService > --------------------------------------- > > Key: HADOOP-12321 > URL: https://issues.apache.org/jira/browse/HADOOP-12321 > Project: Hadoop Common > Issue Type: New Feature > Affects Versions: 2.8.0 > Reporter: Steve Loughran > Assignee: Sunil G > Attachments: 0001-HADOOP-12321.patch, 0002-HADOOP-12321.patch, > HADOOP-12321-003.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > The new JVM pause monitor has been written with its own start/stop lifecycle > which has already proven brittle to both ordering of operations and, even > after HADOOP-12313, is not thread safe (both start and stop are potentially > re-entrant). > It also requires every class which supports the monitor to add another field > and perform the lifecycle operations in its own lifecycle, which, for all > Yarn services, is the YARN app lifecycle (as implemented in Hadoop common) > Making the monitor a subclass of {{AbstractService}} and moving the > init/start & stop operations in {{serviceInit()}}, {{serviceStart()}} & > {{serviceStop()}} methods will fix the concurrency and state model issues, > and make it trivial to add as a child to any YARN service which subclasses > {{CompositeService}} (most the NM and RM apps) will be able to hook up the > monitor simply by creating one in the ctor and adding it as a child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)