[ 
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagadesh Kiran N updated HADOOP-4258:
-------------------------------------
    Attachment: HADOOP-4258.HADOOP-12111.02.patch

thanks for your review [~sekikn]  , attached the patch which covers all your 
comments , except 
{code } 
a new file was added because it conflicted with a pre-existing file in the 
source tree
{code}
Please review the approach for new files we will have function like
{code} function checkifduplicate {code}  common for both added or changed files.
Please let me know your views also 

> the test patch script should check for filenames that differ only in case
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-4258
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4258
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build, test
>            Reporter: Owen O'Malley
>            Assignee: Jagadesh Kiran N
>              Labels: test-patch
>         Attachments: HADOOP-4258.001.patch, 
> HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch, 
> HADOOP-4258.HADOOP-12111.02.patch
>
>
> It would be nice if the test patch script warned about filenames that differ 
> only in case. We recently had a patch committed that had a pair of colliding 
> filenames and subversion broke badly on my Mac.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to