[
https://issues.apache.org/jira/browse/HADOOP-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949425#comment-14949425
]
Allen Wittenauer commented on HADOOP-12364:
-------------------------------------------
Umm, those shellcheck errors are wrong.
Here's what shellcheck 0.4.1 says:
{code}
./hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:1678:13:
warning: Declare and assign separately to avoid masking return values. [SC2155]
./hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:1705:9:
warning: Declare and assign separately to avoid masking return values. [SC2155]
./hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:1706:9:
warning: Declare and assign separately to avoid masking return values. [SC2155]
./hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:1711:9:
warning: Declare and assign separately to avoid masking return values. [SC2155]
./hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh:1712:9:
warning: Declare and assign separately to avoid masking return values. [SC2155]
{code}
Basically, move the "local foo" to the top, then set "foo=bar" later.
Still looking at the rest of the patch, but thought I'd share that part. :)
> Deleting pid file after stop is causing the daemons to keep restarting
> -----------------------------------------------------------------------
>
> Key: HADOOP-12364
> URL: https://issues.apache.org/jira/browse/HADOOP-12364
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Siqi Li
> Assignee: Siqi Li
> Priority: Minor
> Attachments: HADOOP-12364.v1.patch, HADOOP-12364.v2.patch,
> HADOOP-12364.v3.patch
>
>
> pid files are deleting in 5 seconds after we stop the daemons. If a start
> command were executed within the 5 seconds, the pid file will be overwrite
> with a new pid. However, this pid file is going to be deleted by the former
> stop command. This is causing the monitoring service to lose track of the
> daemons, hence keep rebooting them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
