[
https://issues.apache.org/jira/browse/HADOOP-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952469#comment-14952469
]
Gera Shegalov commented on HADOOP-12469:
----------------------------------------
Hi [~liuml07], thanks for working on the patch. Regarding the unit test you
should consider a full distcp test where you create a file and make it unusable
by setting 000 permission. DistCp should be run doAs non-cluster-root user.
bq. Should we address the orthogonal ignoreFailures mutually exclusive with the
atomic option separately?
Sure, will you file it?
> distcp shout not ignore the ignoreFailures option
> -------------------------------------------------
>
> Key: HADOOP-12469
> URL: https://issues.apache.org/jira/browse/HADOOP-12469
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools/distcp
> Affects Versions: 2.7.1
> Reporter: Gera Shegalov
> Assignee: Mingliang Liu
> Priority: Critical
> Fix For: 2.8.0
>
> Attachments: HADOOP-12469.000.patch
>
>
> {{RetriableFileCopyCommand.CopyReadException}} is double-wrapped via
> # via {{RetriableCommand::execute}}
> # via {{CopyMapper#copyFileWithRetry}}
> before {{CopyMapper::handleFailure}} tests
> {code}
> if (ignoreFailures && exception.getCause() instanceof
> RetriableFileCopyCommand.CopyReadException
> {code}
> which is always false.
> Orthogonally, ignoring failures should be mutually exclusive with the atomic
> option otherwise an incomplete dir is eligible for commit defeating the
> purpose.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
