[
https://issues.apache.org/jira/browse/HADOOP-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957464#comment-14957464
]
Hadoop QA commented on HADOOP-12478:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 20m 43s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 4 new or modified test files. |
| {color:green}+1{color} | javac | 7m 58s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 28s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 19s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 42s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 7m 21s | Tests passed in
hadoop-common. |
| {color:green}+1{color} | yarn tests | 2m 1s | Tests passed in
hadoop-yarn-common. |
| {color:green}+1{color} | yarn tests | 8m 50s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 67m 56s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12766575/HADOOP-12478-001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0d77e85 |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7813/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7813/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-yarn-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7813/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7813/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7813/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7813/console |
This message was automatically generated.
> Shell.getWinUtilsPath() has been renamed Shell.getWinutilsPath()
> ------------------------------------------------------------------
>
> Key: HADOOP-12478
> URL: https://issues.apache.org/jira/browse/HADOOP-12478
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Critical
> Attachments: HADOOP-12478-001.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The shell enhancements of HADOOP-10775 managed to unintentionally change
> {{Shell.getWinUtilsPath()}} has been renamed {{Shell.getWinutilsPath()}}.
> This didn't crop in Hadoop's code, but it's broken some of my stuff
> downstream -stuff in Groovy which the IDE didn't pick up as a regression.
> I'll fix things by renaming the method to its original name, and changing the
> name of the {{getWinutilsFile()}} to match
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
