[
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959656#comment-14959656
]
Robert Kanter commented on HADOOP-12101:
----------------------------------------
Overall looks good. A few minor comments:
- In the usage output, {{mode}} should be {{<mode>}}
- If you do the {{all}} mode, it prints out the location of the output file
after each maven run, so earlier runs get buried (or lost depending on scroll
back). We should print them all out at the end when doing {{all}}.
- We could save some time and lots of output when running all by having it use
the same maven invocation for all of them. In other words, {{mvn test
-Dtest=TestHdfsConfigFields,TestMapreduceConfigFields,TestYarnConfigurationFields}}
instead of three separate {{mvn test}} runs.
- When running the {{yarn}} mode, it doesn't print out the location of the
output file, though I don't see why.
> Add automatic search of default Configuration variables to
> TestConfigurationFieldsBase
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-12101
> URL: https://issues.apache.org/jira/browse/HADOOP-12101
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 2.7.0
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Labels: supportability
> Attachments: HADOOP-12101.001.patch, HADOOP-12101.002.patch,
> HADOOP-12101.003.patch, HADOOP-12101.004.patch
>
>
> Add functionality given a Configuration variable FOO, to at least check the
> xml file value against DEFAULT_FOO.
> Without waivers and a mapping for exceptions, this can probably never be a
> test method that generates actual errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
