[ 
https://issues.apache.org/jira/browse/HADOOP-12480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960405#comment-14960405
 ] 

Vinayakumar B commented on HADOOP-12480:
----------------------------------------

bq. a) It's only a few minutes
Yes, its only a few minutes, compared to overall precommit builds. But for 
smaller module patches, where test runs takes relatively very less time, then 
improvement looks significant.

bq. b) this is already fixed in yetus, which hadoop will move to soon so 
patching this is sort of wasted effort.
Its nice to hear about yetus. Waiting for its arrival in Hadoop.

bq. I'm not opposed to the change though. This might be another case where the 
whole community needs to pay more attention to the nightly builds instead of 
just pre-commit to catch problems like this.
Thats correct.

> Run precommit javadoc only for changed modules
> ----------------------------------------------
>
>                 Key: HADOOP-12480
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12480
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HADOOP-12480-01.patch, HADOOP-12480-02.patch, 
> HADOOP-12480-03.patch, HADOOP-12480-04.patch
>
>
> Currently Precommit javadoc check will happen on root of hadoop,
> IMO Its sufficient to run for only changed modules.
> This way Pre-commit will take even lesser time as Javadoc will take 
> significant time compare to other checks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to