[
https://issues.apache.org/jira/browse/HADOOP-11149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960464#comment-14960464
]
Vinayakumar B commented on HADOOP-11149:
----------------------------------------
Adding rule for all tests and unifying the @After method is good.
Just one comment,
Some tests, not even start the cluster. For such tests, @After method will log
NPE. I think simple null check inside {{MiniZKFCCluster.stop}} would be better,
{noformat}2015-10-16 15:36:47,043 WARN ha.ClientBaseWithFixes
(TestZKFailoverController.java:teardown(92)) - When stopping the cluster
java.lang.NullPointerException
at org.apache.hadoop.ha.MiniZKFCCluster.stop(MiniZKFCCluster.java:136)
at
org.apache.hadoop.ha.TestZKFailoverController.teardown(TestZKFailoverController.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method){noformat}
Rest looks good.
> TestZKFailoverController times out
> ----------------------------------
>
> Key: HADOOP-11149
> URL: https://issues.apache.org/jira/browse/HADOOP-11149
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 2.5.0, 2.5.1, 3.0.0
> Environment: Jenkins
> Reporter: Rajat Jain
> Assignee: Steve Loughran
> Attachments: HADOOP-11149-001.patch
>
>
> {code}
> Running org.apache.hadoop.ha.TestZKFailoverController
> Tests run: 19, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 56.875 sec
> <<< FAILURE! - in org.apache.hadoop.ha.TestZKFailoverController
> testGracefulFailover(org.apache.hadoop.ha.TestZKFailoverController) Time
> elapsed: 25.045 sec <<< ERROR!
> java.lang.Exception: test timed out after 25000 milliseconds
> at java.lang.Object.wait(Native Method)
> at
> org.apache.hadoop.ha.ZKFailoverController.waitForActiveAttempt(ZKFailoverController.java:467)
> at
> org.apache.hadoop.ha.ZKFailoverController.doGracefulFailover(ZKFailoverController.java:657)
> at
> org.apache.hadoop.ha.ZKFailoverController.access$400(ZKFailoverController.java:61)
> at
> org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:602)
> at
> org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:599)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:415)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1621)
> at
> org.apache.hadoop.ha.ZKFailoverController.gracefulFailoverToYou(ZKFailoverController.java:599)
> at
> org.apache.hadoop.ha.ZKFCRpcServer.gracefulFailover(ZKFCRpcServer.java:94)
> at
> org.apache.hadoop.ha.TestZKFailoverController.testGracefulFailover(TestZKFailoverController.java:448)
> Results :
> Tests in error:
> TestZKFailoverController.testGracefulFailover:448->Object.wait:-2 ยป test
> time...
> {code}
> Running on centos6.5
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
