[
https://issues.apache.org/jira/browse/HADOOP-12484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964109#comment-14964109
]
Gaurav Kanade commented on HADOOP-12484:
----------------------------------------
[~cnauroth] Addressed your comments above.
With respect to tests: In this particular case the patch seems extremely
straightforward but hard to test with unit tests or custom patch tests as this
issue is exposed by hDP 2.3 integration tests that inject random failures.
It would be good to have a thorough code review instead. [~linchan],
[~pravinmittal] for reference
> Single File Rename Throws Incorrectly In Potential Race Condition Scenarios
> ---------------------------------------------------------------------------
>
> Key: HADOOP-12484
> URL: https://issues.apache.org/jira/browse/HADOOP-12484
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools
> Reporter: Gaurav Kanade
> Assignee: Gaurav Kanade
> Attachments: HADOOP-12484.01.patch, HADOOP-12484.02.patch,
> HADOOP-12484.03.patch, HADOOP-12484.04.patch
>
>
> FinishSingleFileRename function - in the case where src and dst both exist
> gets a lease on src blob to block write access and then deletes the file.
> However in the time between checking existence of source file and acquiring
> lease the file may be deleted by another process (race condition). Presently
> the function simply throws in this scenario. In this case the function should
> treat this as a case where rename is complete; i.e. catch the exception and
> if this is the cause exit gracefully with the result that the rename is
> complete
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
