[
https://issues.apache.org/jira/browse/HADOOP-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970075#comment-14970075
]
Sangjin Lee commented on HADOOP-11883:
--------------------------------------
[~jeagles], thanks for updating the patch. I tried it out, and it looks good to
me for the most part. I have only a couple of comments.
As for the hadoop-build-tools dependencyManagement, I think the standard place
for dependencyManagement is hadoop-project/pom.xml rather than the top level
pom.xml file. I know currently it has clover there now, but it would be good to
consolidate it into hadoop-project/pom.xml. Thoughts?
Also, it appears that maven is retiring the maven eclipse plugin in favor of
using the m2eclipse (eclipse) plugin directly (i.e. importing hadoop as maven
projects). Recently there was an email thread about us switching over to using
the m2eclipse plugin over the "mvn eclipse:eclipse" route. What is your
thought? Does that change how we deal with the checkstyle (or make this change
unnecessary)?
> Checkstyle Results are Different Between Command Line and Eclipse
> -----------------------------------------------------------------
>
> Key: HADOOP-11883
> URL: https://issues.apache.org/jira/browse/HADOOP-11883
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Labels: BB2015-05-TBR, build
> Attachments: HADOOP-11883.1.patch, HADOOP-11883.2.patch,
> HADOOP-11883.3.patch, HADOOP-11883.4.patch, HADOOP-11883.5.patch
>
>
> If I run the checkstyle plugin from with eclipse, I want it to apply the same
> rules as when run from the command line.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
