[
https://issues.apache.org/jira/browse/HADOOP-12385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-12385:
-----------------------------------
Hadoop Flags: Reviewed
+1 for the patch. Thanks for addressing the feedback, Steve.
I think Checkstyle is freaking out because of the indentation style on case
labels in {{SaslRpcClient}}. It currently uses this:
{code}
switch (method) {
case TOKEN:
// Code goes here.
{code}
Checkstyle wants us to do this instead:
{code}
switch (method) {
case TOKEN:
// Code goes here.
{code}
Your patch isn't responsible for introducing this, and I don't consider it in
scope of this patch to reformat the whole file.
{{TestIPC}} passes locally for me. This has been a racy test.
> include nested stack trace in SaslRpcClient.getServerToken()
> ------------------------------------------------------------
>
> Key: HADOOP-12385
> URL: https://issues.apache.org/jira/browse/HADOOP-12385
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 2.7.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-12385-001.patch, HADOOP-12385-002.patch,
> HADOOP-12385-003.patch
>
>
> The {{SaslRpcClient.getServerToken()}} method loses the stack traces when an
> attempt to instantiate a {{TokenSelector}}. It should include them in the
> generated exception
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
