[
https://issues.apache.org/jira/browse/HADOOP-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980422#comment-14980422
]
Varun Vasudev commented on HADOOP-10787:
----------------------------------------
[~aw] - the issue still exists on my mac and the linux vm.
On my mac -
{code}
hadoop-common vvasudev$ pwd
/Users/vvasudev/Workspace/apache/hadoop/hadoop-common-project/hadoop-common
hadoop-common vvasudev$ mvn clean package install -DskipTests
-Dmaven.javadoc.skip=true
{code}
results in
{code}
[exec] 1..3
[exec] not ok 1 hadoop_add_common_to_classpath (negative)
[exec] # (from function `freetheclasses' in file
hadoop_add_common_to_classpath.bats, line 27,
[exec] # in test file hadoop_add_common_to_classpath.bats, line 45)
[exec] # `freetheclasses' failed
[exec] # bindir:
/Users/vvasudev/Workspace/apache/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /var/folders/n1/klkrb91135d8s9xl7m4gcsgw0000gp/T/bats.97469.src:
line 27: unset: `/Users/vvasudev/Workspace/current-hadoop': not a valid
identifier
[exec] not ok 2 hadoop_add_common_to_classpath (positive)
[exec] # (from function `freetheclasses' in file
hadoop_add_common_to_classpath.bats, line 27,
[exec] # in test file hadoop_add_common_to_classpath.bats, line 53)
[exec] # `freetheclasses' failed
[exec] # bindir:
/Users/vvasudev/Workspace/apache/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /var/folders/n1/klkrb91135d8s9xl7m4gcsgw0000gp/T/bats.97469.src:
line 27: unset: `/Users/vvasudev/Workspace/current-hadoop': not a valid
identifier
[exec] not ok 3 hadoop_add_common_to_classpath (build paths)
[exec] # (from function `freetheclasses' in file
hadoop_add_common_to_classpath.bats, line 27,
[exec] # in test file hadoop_add_common_to_classpath.bats, line 63)
[exec] # `freetheclasses' failed
[exec] # bindir:
/Users/vvasudev/Workspace/apache/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /var/folders/n1/klkrb91135d8s9xl7m4gcsgw0000gp/T/bats.97469.src:
line 27: unset: `/Users/vvasudev/Workspace/current-hadoop': not a valid
identifier
[exec] Running bats -t hadoop_add_javalibpath.bats
{code}
which means that I can't run a build with bats enabled(even if I skip tests).
In my .profile, I have
{code}
export HADOOP_INSTALL=/Users/vvasudev/Workspace/current-hadoop
{code}
The bash version is -
{code}
hadoop-common vvasudev$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin14)
Copyright (C) 2007 Free Software Foundation, Inc.
hadoop-common vvasudev$
{code}
The root cause seems to the function freetheclasses in
hadoop_add_common_to_classpath.bats - the unset in that function gives the
error.
> Rename/remove non-HADOOP_*, etc from the shell scripts
> ------------------------------------------------------
>
> Key: HADOOP-10787
> URL: https://issues.apache.org/jira/browse/HADOOP-10787
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Labels: scripts
> Attachments: HADOOP-10787.00.patch, HADOOP-10787.01.patch,
> HADOOP-10787.02.patch, HADOOP-10787.03.patch, HADOOP-10787.04.patch
>
>
> We should make an effort to clean up the shell env var name space by removing
> unsafe variables. See comments for list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
