Staffan Friberg created HADOOP-12528:
----------------------------------------
Summary: Avoid spinning in CallQueueManager.take()
Key: HADOOP-12528
URL: https://issues.apache.org/jira/browse/HADOOP-12528
Project: Hadoop Common
Issue Type: Improvement
Components: performance
Affects Versions: 2.7.1
Reporter: Staffan Friberg
Priority: Minor
Attachments: HADOOP-12528.001.patch
When IPC threads (Server$Handler) does take() to get the next Call, the
CallManager does a poll instead of take() on the internal queue.
This causes threads to wake up and unnecessarily waste some CPU and do extra
allocation as part of the internal await/signal mechanism each time the thread
redoes poll().
This patch uses take() on the queue instead of poll() which will keep thread in
the await state until work is available. Since threads will be blocked on the
queue indefinitely the swapping of queues requires a bit of extra work to make
sure threads wake up and does take on the new queue.
Updated the test TestCallQueueManager.testSwapUnderContention() to ensure that
no threads get stuck on the old queue as part of swapping.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
