[
https://issues.apache.org/jira/browse/HADOOP-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008309#comment-15008309
]
Akira AJISAKA commented on HADOOP-12348:
----------------------------------------
TestLazyPersistFiles is failing in branch-2.7 after backporting this issue.
{noformat}
Running
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 241.331 sec
<<< FAILURE! - in
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
testFallbackToDiskFull(org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles)
Time elapsed: 1.153 sec <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:542)
at
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.LazyPersistTestCase.verifyRamDiskJMXMetric(LazyPersistTestCase.java:404)
at
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles.testFallbackToDiskFull(TestLazyPersistFiles.java:164)
Results :
Failed tests:
TestLazyPersistFiles.testFallbackToDiskFull:164->LazyPersistTestCase.verifyRamDiskJMXMetric:404
expected:<1> but was:<0>
Tests run: 24, Failures: 1, Errors: 0, Skipped: 0
{noformat}
> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.
> ------------------------------------------------------------------------------
>
> Key: HADOOP-12348
> URL: https://issues.apache.org/jira/browse/HADOOP-12348
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Reporter: zhihai xu
> Assignee: zhihai xu
> Fix For: 2.8.0, 2.7.3
>
> Attachments: HADOOP-12348.000.patch, HADOOP-12348.001.patch,
> HADOOP-12348.branch-2.patch
>
>
> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit
> parameter. MetricsSourceAdapter expects time unit millisecond for
> jmxCacheTTL but MetricsSystemImpl passes time unit second to
> MetricsSourceAdapter constructor.
> {code}
> jmxCacheTS = Time.now() + jmxCacheTTL;
> /**
> * Current system time. Do not use this to calculate a duration or interval
> * to sleep, because it will be broken by settimeofday. Instead, use
> * monotonicNow.
> * @return current time in msec.
> */
> public static long now() {
> return System.currentTimeMillis();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
