[
https://issues.apache.org/jira/browse/HADOOP-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012994#comment-15012994
]
Tsuyoshi Ozawa commented on HADOOP-12575:
-----------------------------------------
[~lewuathe] thank you for taking this issue. Followings are my review comments
- could you update the patch?
1. The configuration looks to be for a driver of softlayer. We can remove it.
{code}
+ --softlayer-memory "4096" \
{code}
2. The docker machine name {{default}} can be conflicted. For a workaround,
it's better to name {{hadoopdev}.
3. Why 4094? Typo of 4096?
{code}
+ --virtualbox-memory "4094" default
{code}
> Build instruction for docker toolbox
> ------------------------------------
>
> Key: HADOOP-12575
> URL: https://issues.apache.org/jira/browse/HADOOP-12575
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Trivial
> Labels: docker, documentation
> Attachments: HADOOP-12575.01.patch
>
>
> Currently docker on MacOSX is mainly used by docker toolbox and
> docker-machine. These tools make boot2docker deprecated.
> (https://docs.docker.com/engine/installation/mac/)
> It might be better to append the instruction of docker toolbox and
> docker-machine when using {{start-build-env.sh}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
