[
https://issues.apache.org/jira/browse/HADOOP-12176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021308#comment-15021308
]
Hadoop QA commented on HADOOP-12176:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 0s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 0s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
8s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 37s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12743272/HADOOP-12176-01.patch
|
| JIRA Issue | HADOOP-12176 |
| Optional Tests | asflicense mvnsite unit shellcheck |
| uname | Linux 8171777e831f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 5f68845 |
| shellcheck | v0.4.1 |
| JDK v1.7.0_85 Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/8123/testReport/ |
| modules | C: U: |
| Max memory used | 29MB |
| Powered by | Apache Yetus http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/8123/console |
This message was automatically generated.
> smart-apply-patch.sh fails to identify git patch prefixes in some cases
> -----------------------------------------------------------------------
>
> Key: HADOOP-12176
> URL: https://issues.apache.org/jira/browse/HADOOP-12176
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HADOOP-12176-01.patch
>
>
> after HADOOP-12018, git apply supported with --no-prefix.
> But for some patches this detection will identify git patch with prefix as
> no-prefix patch and fails to apply.
> Example case is ; If patch contains a line changed with '+++' or '---'
> somewhere in between. May be a javadoc update. This makes detection wrong and
> git apply will fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
