[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021362#comment-15021362
]
Haohui Mai commented on HADOOP-9822:
------------------------------------
Looks good to me overall.
{code}
private final int MAX_CAPACITY = 16;
{code}
Should be private static final.
> create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in
> RetryCache constructor
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-9822
> URL: https://issues.apache.org/jira/browse/HADOOP-9822
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.3.0
> Reporter: Tsuyoshi Ozawa
> Assignee: Tsuyoshi Ozawa
> Priority: Minor
> Labels: BB2015-05-TBR
> Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch,
> HADOOP-9822.3.patch
>
>
> The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding
> magic number "16" is a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
