[
https://issues.apache.org/jira/browse/HADOOP-12546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024340#comment-15024340
]
Steve Loughran commented on HADOOP-12546:
-----------------------------------------
looks almost ready to go, except you should be checking IOE.toString(), not
getMessage(), as that may actually be null.
I recommend you switch to {{GenericTestUtils.assertExceptionContains()}} there
for both the robustness and the way on any failure it includes the stack
trace/exception caught in the new failure
> Improve TestKMS
> ---------------
>
> Key: HADOOP-12546
> URL: https://issues.apache.org/jira/browse/HADOOP-12546
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 2.7.1
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: HADOOP-12546.001.patch
>
>
> The TestKMS class has some issues:
> * It swallows some exceptions' stack traces
> * It swallows some exceptions altogether
> * Some of the tests aren't as tight as they could be
> * Asserts lack messages
> * Code style is a bit hodgepodge
> This JIRA is to clean all that up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
