On Jul 21, 2005, at 8:40 PM, Paul Libbrecht wrote:

I've seen that.... mmmh.... so we should "just revert to not- caching" (by default) then test and change the ones that need caching, correct ?


potentially :)


Right, now, I "just did this" (it's just a few lines of code) and... well... I have, simply in core... the following tests failing:

TestChooseTag, TestForEachTag, TestInvokeStaticTag, TestInvokeTag, TestNewTag, TestSwitchTag, TestJelly

And they all succeed if I change JellyContext.cacheTags to true.
Moreover I remember that jelly:define was my major goal when making always caching...

Should I really commit that and then hunt individual failures with such a method as "TagScript.doCacheMe"?
Wouldn't a method "Tag.reset()" make more sense ?


No, don't commit yet.

I'll do what you did and spend some time tomorrow looking at the failures to see if we can have nirvana (no memory leak + exact behavior semantics from when we had the leak).
-pete

--
peter royal


Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to