Author: niallp
Date: Thu Nov 23 05:09:27 2006
New Revision: 478560
URL: http://svn.apache.org/viewvc?view=rev&rev=478560
Log:
VALIDATOR-190 - EmailValidator allows control characters (ASCII 0-31 and 127) -
thanks to Cott and Gabriel Belingueres
Modified:
jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/EmailValidator.java
jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/EmailTest.java
jakarta/commons/proper/validator/trunk/xdocs/changes.xml
Modified:
jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/EmailValidator.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/EmailValidator.java?view=diff&rev=478560&r1=478559&r2=478560
==============================================================================
---
jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/EmailValidator.java
(original)
+++
jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/EmailValidator.java
Thu Nov 23 05:09:27 2006
@@ -38,7 +38,7 @@
*/
public class EmailValidator {
- private static final String SPECIAL_CHARS =
"\\(\\)<>@,;:'\\\\\\\"\\.\\[\\]";
+ private static final String SPECIAL_CHARS =
"\\000-\\037\\(\\)<>@,;:'\\\\\\\"\\.\\[\\]\\177";
private static final String VALID_CHARS = "[^\\s" + SPECIAL_CHARS + "]";
private static final String QUOTED_USER = "(\"[^\"]*\")";
private static final String ATOM = VALID_CHARS + '+';
Modified:
jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/EmailTest.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/EmailTest.java?view=diff&rev=478560&r1=478559&r2=478560
==============================================================================
---
jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/EmailTest.java
(original)
+++
jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/EmailTest.java
Thu Nov 23 05:09:27 2006
@@ -221,6 +221,18 @@
}
+ /**
+ * Tests the email validation with ascii control characters.
+ * (i.e. Ascii chars 0 - 31 and 127)
+ */
+ public void testEmailWithControlChars() throws ValidatorException {
+ EmailValidator validator = new EmailValidator();
+ for (char c = 0; c < 32; c++) {
+ assertFalse("Test control char " + ((int)c),
validator.isValid("foo" + c + "[EMAIL PROTECTED]"));
+ }
+ assertFalse("Test control char 127", validator.isValid("foo" +
((char)127) + "[EMAIL PROTECTED]"));
+ }
+
/**
* Write this test according to parts of RFC, as opposed to the type of
character
* that is being tested.
Modified: jakarta/commons/proper/validator/trunk/xdocs/changes.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/xdocs/changes.xml?view=diff&rev=478560&r1=478559&r2=478560
==============================================================================
--- jakarta/commons/proper/validator/trunk/xdocs/changes.xml (original)
+++ jakarta/commons/proper/validator/trunk/xdocs/changes.xml Thu Nov 23
05:09:27 2006
@@ -40,6 +40,11 @@
<body>
<release version="1.3.1" date="Pending">
+ <action dev="niallp" type="fix" issue="VALIDATOR-190">
+ EmailValidator allows control characters (ASCII 0-31 and 127).
+ <dueto name="Cott"/>
+ <dueto name="Gabriel Belingueres"/>
+ </action>
<action dev="niallp" type="fix" issue="VALIDATOR-210" due-to="Neil
Sherman">
JavaScript Causes HTML Page to Contain Illegal HTML.
</action>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
