[
https://issues.apache.org/jira/browse/LANG-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490375
]
Gary Gregory commented on LANG-329:
-----------------------------------
Before we sign off on this I'd like to know why it is "pointless" and why does
Sun recommend doing it the way the code was before this patch in their
documentation.
Please see:
http://java.sun.com/j2se/1.4.2/docs/api/java/lang/ThreadLocal.html
http://java.sun.com/j2se/1.5.0/docs/api/java/lang/ThreadLocal.html
If you are on 1.6+, you'd do it differently:
http://java.sun.com/javase/6/docs/api/java/lang/ThreadLocal.html
> Pointless synchronized in ThreadLocal.initialValue should be removed
> --------------------------------------------------------------------
>
> Key: LANG-329
> URL: https://issues.apache.org/jira/browse/LANG-329
> Project: Commons Lang
> Issue Type: Improvement
> Affects Versions: 2.3
> Environment: Any
> Reporter: Hanson Char
> Priority: Trivial
> Fix For: 3.0
>
>
> ---
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> 2007/01/27 07:13:59 500497
> +++
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> 2007/04/20 05:06:03 530645
> @@ -103,7 +103,7 @@
> * </p>
> */
> private static ThreadLocal registry = new ThreadLocal() {
> - protected synchronized Object initialValue() {
> + protected Object initialValue() {
> // The HashSet implementation is not synchronized,
> // which is just what we need here.
> return new HashSet();
> ---
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
> 2006/09/19 21:58:11 447989
> +++
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
> 2007/04/20 05:11:46 530648
> @@ -103,7 +103,7 @@
> * @since 2.3
> */
> private static ThreadLocal registry = new ThreadLocal() {
> - protected synchronized Object initialValue() {
> + protected Object initialValue() {
> // The HashSet implementation is not synchronized,
> // which is just what we need here.
> return new HashSet();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
