[
https://issues.apache.org/jira/browse/LANG-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell updated LANG-329:
-------------------------------
Fix Version/s: 3.0
No major problems. Minor ones:
* Set a fix version in JIRA to the next planned version. I'm doing that now
(3.0).
* Common to introduce yourself if people aren't expecting you to be committing
to a component.
* Also somewhat common I think to lag things between the report and the commit
to allow for comments, though no biggy.
This looks like a fine fix to me.
> Pointless synchronized in ThreadLocal.initialValue should be removed
> --------------------------------------------------------------------
>
> Key: LANG-329
> URL: https://issues.apache.org/jira/browse/LANG-329
> Project: Commons Lang
> Issue Type: Improvement
> Affects Versions: 2.3
> Environment: Any
> Reporter: Hanson Char
> Priority: Trivial
> Fix For: 3.0
>
>
> ---
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> 2007/01/27 07:13:59 500497
> +++
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> 2007/04/20 05:06:03 530645
> @@ -103,7 +103,7 @@
> * </p>
> */
> private static ThreadLocal registry = new ThreadLocal() {
> - protected synchronized Object initialValue() {
> + protected Object initialValue() {
> // The HashSet implementation is not synchronized,
> // which is just what we need here.
> return new HashSet();
> ---
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
> 2006/09/19 21:58:11 447989
> +++
> jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
> 2007/04/20 05:11:46 530648
> @@ -103,7 +103,7 @@
> * @since 2.3
> */
> private static ThreadLocal registry = new ThreadLocal() {
> - protected synchronized Object initialValue() {
> + protected Object initialValue() {
> // The HashSet implementation is not synchronized,
> // which is just what we need here.
> return new HashSet();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
