[PATCH] Latka bug

[Jeff Turner]

Found this small bug while poaching code for another project ;) It
presumably would cause an IndexOutOfBoundsException when comparing
zero-length strings.

--Jeff

Index: src/java/org/apache/commons/latka/validators/GoldenFileValidator.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-commons/latka/src/java/org/apache/commons/latka/validators/GoldenFileValidator.java,v
retrieving revision 1.4
diff -u -r1.4 GoldenFileValidator.java
--- src/java/org/apache/commons/latka/validators/GoldenFileValidator.java       
2001/09/07 19:45:45     1.4
+++ src/java/org/apache/commons/latka/validators/GoldenFileValidator.java       
+2001/12/22 05:21:24
@@ -149,7 +149,7 @@
 
     for (int i=0; i<str1.length() ; i++ ) {
       if (str1.charAt( i ) != str2.charAt( i ) ) {
-        log("Error at " + i  + " " + str1.charAt(1) +
+        log("Error at " + i  + " " + str1.charAt(i) +
             str2.charAt(i));
         return false;
       }

Index: src/java/org/apache/commons/latka/validators/GoldenFileValidator.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-commons/latka/src/java/org/apache/commons/latka/validators/GoldenFileValidator.java,v
retrieving revision 1.4
diff -u -r1.4 GoldenFileValidator.java
--- src/java/org/apache/commons/latka/validators/GoldenFileValidator.java       
2001/09/07 19:45:45     1.4
+++ src/java/org/apache/commons/latka/validators/GoldenFileValidator.java       
+2001/12/22 05:21:24
@@ -149,7 +149,7 @@
 
     for (int i=0; i<str1.length() ; i++ ) {
       if (str1.charAt( i ) != str2.charAt( i ) ) {
-        log("Error at " + i  + " " + str1.charAt(1) +
+        log("Error at " + i  + " " + str1.charAt(i) +
             str2.charAt(i));
         return false;
       }


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>