> I was talking about the one in cvs.  I was trying to point
> out that there
> are other classes that suffer from the same problem that you
> are fixing and
> that there are other problems with one of the LRU
> implementations.  See the
> other emails.

ok.  I've looked over some of the classes you mentioned.  LRUMap in
commons.collections definately suffers the same problems.  I'm about to
post a patch for that class that enumerates some of the problems that I
saw (I didn't fix them yet -- the patch just changes the license to the
proper long form and documents the problems).

Assuming you mean org.apache.turbine.util.BufferCache when you referred
to BufferCache, I looked it over as well.  It inherits from
org.apache.turbine.util.SequencedHashtable which looks to be a near
exact duplicate of the SequencedHashtable that's in commons.util and
nearly the same as the SequencedHashMap that exists in
commons.collections (which is the one I submitted my patch against).

I can't find any reference to MRUMap.  Can you give me a pointer?

The LRUStore you added to stratum looks good to me; however I think its
a bit too restricting by requiring contents to be instances of
ILRUElement and for the keys and values to be Serializable.  Seems like
it would work for your needs though.  :)


Overall, yes, there are other classes that suffer from the problem I was
fixing with commons.collections.SequencedHashMap.  I'm working on fixing
the stuff in commons, since that's what has my interest.  LRUMap is on
my list of things to fix.  Of course, this all assumes my patches will
get applied eventually.  :)

regards,
michael



--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to