Of course...

greets,
Klaasjan Brand


Scott Sanders wrote:
> Could you post the patch again?
> 
> Thanks
> Scott
> 
> 
>>-----Original Message-----
>>From: Klaasjan Brand [mailto:[EMAIL PROTECTED]] 
>>Sent: Monday, April 08, 2002 12:14 AM
>>To: Jakarta Commons Developers List
>>Subject: Re: BeanUtils and Digester Release?
>>
>>
>>Scott Sanders wrote:
>>
>>>Anyone hae any blockers that would stop the release of 
>>
>>BeanUtils 1.3 
>>
>>>or Digester 1.2?
>>>
>>>Digester has the XML rules stuff that I would like to get released, 
>>>and both have had some good bugfixes.
>>>
>>>Opiniions, suggestions?
>>>
>>>Scott Sanders
>>>
>>
>>I mentioned a bug in MethodUtils a few days back: 
>>http://nagoya.apache.org/bugzilla/show_bug.cgi> ?id=7740
>>
>>I've 
>>provided a patch, but it's not yet committed.
>>
>>It would be nice if the fix would be included...
>>
>>greets,
>>Klaasjan Brand
>>
>>
--- orig/MethodUtils.java       Wed Apr  3 13:50:22 2002
+++ fix/MethodUtils.java        Wed Apr  3 13:50:34 2002
@@ -504,7 +504,7 @@
         // search through all methods 
         int paramSize = parameterTypes.length;
         Method[] methods = clazz.getMethods();
-        for (int i = 0, size = methods.length; i < size ; i++) {
+        outer: for (int i = 0, size = methods.length; i < size ; i++) {
             if (methods[i].getName().equals(methodName)) {     
                 // log some trace information
                 if (log.isTraceEnabled()) {
@@ -517,12 +517,12 @@
                 int methodParamSize = methodsParams.length;
                 if (methodParamSize == paramSize) {                    
                     for (int n = 0 ; n < methodParamSize; n++) {
-                        if (!parameterTypes[n].isAssignableFrom(methodsParams[n])) {
+                        if (!methodsParams[n].isAssignableFrom(parameterTypes[n])) {
                             if (log.isTraceEnabled()) {
                                 log.trace(parameterTypes[n] + " is not assignable 
from " 
                                             + methodsParams[n]);
                             }    
-                            break;
+                            continue outer;
                         }
                     }
                     

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to