craigmcc 02/04/20 11:31:01
Modified: dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java
Log:
If createDataSource() cannot load the driver class or instantiate an instance,
log the error to our local logWriter instead of calling getLogWriter() and
causing a stack overflow.
PR: Bugzilla #7727
Submitted by: James House <james at interobjective.com>
Revision Changes Path
1.3 +8 -8
jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java
Index: BasicDataSource.java
===================================================================
RCS file:
/home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- BasicDataSource.java 17 Mar 2002 14:55:20 -0000 1.2
+++ BasicDataSource.java 20 Apr 2002 18:31:01 -0000 1.3
@@ -1,6 +1,6 @@
-/** $Header:
/home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java,v
1.2 2002/03/17 14:55:20 rwaldhoff Exp $
- * $Revision: 1.2 $
- * $Date: 2002/03/17 14:55:20 $
+/** $Header:
/home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java,v
1.3 2002/04/20 18:31:01 craigmcc Exp $
+ * $Revision: 1.3 $
+ * $Date: 2002/04/20 18:31:01 $
*
* ====================================================================
*
@@ -79,7 +79,7 @@
* but provides a "one stop shopping" solution for basic requirements.</p>
*
* @author Craig R. McClanahan
- * @version $Revision: 1.2 $ $Date: 2002/03/17 14:55:20 $
+ * @version $Revision: 1.3 $ $Date: 2002/04/20 18:31:01 $
*/
public class BasicDataSource implements DataSource {
@@ -427,8 +427,8 @@
} catch (Throwable t) {
String message = "Cannot load JDBC driver class '" +
driverClassName + "'";
- getLogWriter().println(message);
- t.printStackTrace(getLogWriter());
+ logWriter.println(message);
+ t.printStackTrace(logWriter);
throw new SQLException(message);
}
@@ -439,8 +439,8 @@
} catch (Throwable t) {
String message = "Cannot create JDBC driver of class '" +
driverClassName + "'";
- getLogWriter().println(message);
- t.printStackTrace(getLogWriter());
+ logWriter.println(message);
+ t.printStackTrace(logWriter);
throw new SQLException(message);
}
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
