Sorry for the cross-post, but this seems an appropriate occasion. Future
discussion might reasonably move to the commons-dev list.
As previously mentioned on commons-dev, we'd like to change the ObjectPool
and KeyedObjectPool numActive and numIdle methods into the more common
getNumActive and getNumIdle style of getter.
As far as I can tell, the only place in Jakarta land that is currently using
numActive or numIdle directly (or at least, the only places I can't update
directly) is in the TurbineIntakeService class at
jakarta-turbine-fulcrum/src/services/org/apache/fulcrum/intake/TurbineIntake
Service.java
Specifically, the getSize(String) method uses KeyedObjectPool.numActive and
KeyedObjectPool.numIdle:
I've just deprecated those methods in KeyedObjectPool, and I'd like to
remove them altogether before the next pool release. If someone could
change the TurbineIntakeService.getSize method to:
public int getSize(String name)
{
return keyedPool.getNumActive(name) + keyedPool.getNumIdle(name);
}
then we could complete the change without even breaking anyone's gump build.
Comments or complaints welcome,
- Rod
