On Thu, 17 Oct 2002, Michael A. Smith wrote:
> -1. I think the following issues must be addressed first. +1 on addressing. Thanks for catching them. > 1. The source distributions (both .tar.gz and .zip) do not include the > source for the "iterators" subpackage. Fixed. > 2. In the binary distribution (both .zip and .tar.gz), the > commons-collections.jar contains a Manifest.mf that lists: > Specification-Version: 1.0 > Implementation-Version: 2.0 > > I believe both of these should be 2.1 I've changed the implementation version to 2.1 as this is obvious. Looking at 2.0, it didn't do this at all, says the impl version was 1.1-dev and the spec version was left as 1.0. Should Spec version be 2.0?? > 6. The cvs.root value in the build.properties.sample should probably be > ":pserver:[EMAIL PROTECTED]:/home/cvspublic" instead of > :pserver:username@localhost:/home/cvs. It's a sample, but it'd be nice > if it at least as the potential to work for someone. Fixed. > 7. StaticBucketMap should have an @since Collections 2.1 either to > replace to to augment @since Avalon 4.0. My preference would be to replace. Fixed. I did a replace. Hopefully my decision to do an rc2 is okay. Most of the issues were due to the 1 screwup, and I think I'm now up to par with the peculiarities of the collections-deploy. Incidentally, the LICENSE and MANIFEST.MF from 2.0 contain windows-only line endings [ie, lots of ^Ms], so I assume previous builds were on windows? Hen -- To unsubscribe, e-mail: <mailto:commons-dev-unsubscribe@;jakarta.apache.org> For additional commands, e-mail: <mailto:commons-dev-help@;jakarta.apache.org>
