bayard 2002/11/07 08:59:44
Modified: lang/src/test/org/apache/commons/lang NumberRangeTest.java
lang/src/java/org/apache/commons/lang NumberRange.java
Log:
NumberRange.getMaximum returns the minimum, not the maximum.
Test added to verify this, and then the bug fixed.
SUBMITTED-BY: Kasper R�nning
Revision Changes Path
1.3 +10 -1
jakarta-commons/lang/src/test/org/apache/commons/lang/NumberRangeTest.java
Index: NumberRangeTest.java
===================================================================
RCS file:
/home/cvs/jakarta-commons/lang/src/test/org/apache/commons/lang/NumberRangeTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- NumberRangeTest.java 8 Oct 2002 19:14:20 -0000 1.2
+++ NumberRangeTest.java 7 Nov 2002 16:59:44 -0000 1.3
@@ -100,6 +100,15 @@
return suite;
}
+ public void testMaxMin() {
+ boolean expected = true;
+ boolean result = tenToTwenty.getMaximum().equals(twenty);
+ assertEquals(expected, result);
+
+ expected = true;
+ result = tenToTwenty.getMinimum().equals(ten);
+ assertEquals(expected, result);
+ }
public void testEquals() {
boolean expected = false;
1.2 +2 -2
jakarta-commons/lang/src/java/org/apache/commons/lang/NumberRange.java
Index: NumberRange.java
===================================================================
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/NumberRange.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- NumberRange.java 19 Jul 2002 03:35:54 -0000 1.1
+++ NumberRange.java 7 Nov 2002 16:59:44 -0000 1.2
@@ -126,7 +126,7 @@
* @return the maximum number in this range
*/
public Number getMaximum() {
- return min;
+ return max;
}
/**
--
To unsubscribe, e-mail: <mailto:commons-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@;jakarta.apache.org>
