The big issue is the behavior. My proposal was: if java:env/comp/LoggingDomain is set ( as a String ), it'll be used as a prefix in all loggers ( that don't have a prefix ). The syntax for the logger names will become: DOMAIN:LOGGER And all loggers will have to be configured with this name ( if running in a container env with LoggingDomain support ).
This is very important - and I would like to see more opinions. Maybe we should use the domain as a suffix instead of prefix ? Then you would have: org.apache.foo:host:8080/examples as the log name, but you can set org.apache.foo.* to debug and enable the loggers in all apps. The prefix is cleaner, but the suffix may be easier to configure. For implementation - I'm in no hurry ( I would like to have it before tomcat5 is released - but that's not very close ). And I can use reflecion or a hook, if needed. Costin Richard Sitze wrote: > I'll wait for the formal call to vote before I start voting, BUT I support > the following: > > + release a 1.0.3 before any major code changes > + JNDI > > - NO API changes > - NO new runtime dependencies, and I'd like to be able to build, even if > I cannot test it. > > <ras> > > ******************************************* > Richard A. Sitze > > > > > sounds like a good plan. > > this sounds (to me) like a change big enough to call for a new (major?) > version. > > (i'm not a cvs expert) but from what i can see there have been some small > changes since the last release. maybe a quick bugfix 1.0.3 release would > be a good idea before adding making this change. > > - robert > > On Thursday, December 12, 2002, at 03:29 AM, Costin Manolache wrote: > >> Based on Ceki's email - I think it would be a good idea to add >> this mechanism in the default logging factory. >> >> My proposal is to insert a lookup for >> >> java:comp/env/CommonsLoggingFactory >> >> at the top of the discovery chain. If such a factory exists, it'll >> be used to create the logger. If not, we'll continue with the >> normal mechanism. >> >> The big downsize is that we'll add a compile dependency on >> JNDI ( the code can catch ClassNotFound - and run even if >> JNDI is not present ). >> >> This will allow containers using commons-logging to better enforce >> isolation between apps. >> >> In addition, I think we should add an optional "domain name" prefix. >> If such a prefix is set ( for example in >> java:comp/env/CommonsLoggingDomain) >> then it'll be added in front of every log name that is created. >> >> For example, if the container will set myHost:8080/myApp/ as a prefix, >> logs created in that app will be named: >> myHost:8080/myApp/org.apache..... >> >> >> As a note, web.xml allows you to define and set a number of >> jndi entries. This could also be used to allow user-based tuning, >> but in general the container settings should be able to >> take preference . >> >> Costin >> >> >> >> >> -- >> To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED] > . >> org> >> For additional commands, e-mail: <mailto:[EMAIL PROTECTED] > . >> org> >> > > > -- > To unsubscribe, e-mail: < > mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: < > mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
