Here are the changes I made locally. With these changes, resources
builds and passes on both 1.3.1 and 1.4.1. Just say the word and I'll
commit them.
--
James Mitchell
Software Engineer/Open Source Evangelist
http://www.open-tools.org
"C makes it easy to shoot yourself in the foot; C++ makes it harder, but
when you do, it blows away your whole leg."
- Bjarne Stroustrup
> -----Original Message-----
> From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]]
> Sent: Thursday, January 09, 2003 7:00 PM
> To: Jakarta Commons Developers List
> Subject: Re: [RESOURCES] Units tests rely on JDK 1.4
>
>
> I fixed the cases that I found yesterday evening (Pacific
> time). If you
> run into any more, please provide a patch (diff -u) so that I
> can get them
> all at once.
>
> Craig
>
>
> On Thu, 9 Jan 2003, Robert Leland wrote:
>
> > Date: Thu, 09 Jan 2003 17:43:21 -0500
> > From: Robert Leland <[EMAIL PROTECTED]>
> > Reply-To: Jakarta Commons Developers List
> <[EMAIL PROTECTED]>
> > To: Jakarta Commons Developers List <[EMAIL PROTECTED]>
> > Subject: Re: [RESOURCES] Units tests rely on JDK 1.4
> >
> > Craig R. McClanahan wrote:
> > >
> > > On Thu, 9 Jan 2003, Robert Leland wrote:
> > >
> > >
> > >>Date: Thu, 09 Jan 2003 17:09:48 -0500
> > >>From: Robert Leland <[EMAIL PROTECTED]>
> > >>Reply-To: Jakarta Commons Developers List
> <[EMAIL PROTECTED]>
> > >>To: Jakarta Commons Users List <[EMAIL PROTECTED]>
> > >>Subject: [RESOURCES] Units tests rely on JDK 1.4
> > >>
> > >>Same as before but for Units tests.
> > >>Locale(language),
> > >>doesn't exist under JDK 1.3, only under 1.4.
> > >>
> > >
> > >
> > > As with the cases in the mainline code, this was fixed in
> the 20030109
> > > nightly build (i.e. last night's).
> >
> > I just did a CVS update ~4:45 P.M. EST, so it was fixed
> after that time ?
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> <mailto:commons-dev-> [EMAIL PROTECTED]>
> > For
> additional commands,
> e-mail: <mailto:[EMAIL PROTECTED]>
> >
> >
>
>
> --
> To unsubscribe, e-mail:
> <mailto:commons-dev-> [EMAIL PROTECTED]>
> For
> additional commands,
> e-mail: <mailto:[EMAIL PROTECTED]>
>
>
RCS file:
/home/cvs/jakarta-commons-sandbox/resources/src/test/org/apache/commons/resources/impl/CollectionResourcesBaseTestCase.java,v
retrieving revision 1.2
diff -u -r1.2 CollectionResourcesBaseTestCase.java
--- src/test/org/apache/commons/resources/impl/CollectionResourcesBaseTestCase.java
9 Jan 2003 03:25:24 -0000 1.2
+++ src/test/org/apache/commons/resources/impl/CollectionResourcesBaseTestCase.java
+ 10 Jan 2003 03:25:47 -0000
@@ -172,7 +172,7 @@
test = new Locale("en", "");
expected = new ArrayList();
expected.add(test);
- expected.add(new Locale(""));
+ expected.add(new Locale("",""));
checkLocaleList(test, expected, cresources.getLocaleList(test));
test = new Locale("", "US", "POSIX");
@@ -194,7 +194,7 @@
// Test retrieving missing resource keys
public void testMissing() throws Exception {
- Locale locale = new Locale("en");
+ Locale locale = new Locale("en","");
try {
resources.setReturnNull(true);
String value = resources.getString("test.missing", locale, null);
Index: src/test/org/apache/commons/resources/impl/ResourceBundleResourcesTestCase.java
===================================================================
RCS file:
/home/cvs/jakarta-commons-sandbox/resources/src/test/org/apache/commons/resources/impl/ResourceBundleResourcesTestCase.java,v
retrieving revision 1.2
diff -u -r1.2 ResourceBundleResourcesTestCase.java
--- src/test/org/apache/commons/resources/impl/ResourceBundleResourcesTestCase.java
28 Dec 2002 04:40:56 -0000 1.2
+++ src/test/org/apache/commons/resources/impl/ResourceBundleResourcesTestCase.java
+ 10 Jan 2003 03:25:47 -0000
@@ -147,7 +147,7 @@
// Test retrieving missing resource keys
public void testMissing() throws Exception {
- Locale locale = new Locale("en");
+ Locale locale = new Locale("en","");
try {
resources.setReturnNull(false);
String value = resources.getString("test.missing", locale, null);
@@ -180,7 +180,7 @@
Locale locale = null;
- locale = new Locale("en");
+ locale = new Locale("en","");
assertEquals("en specific value",
"[en] SPECIFIC",
resources.getString("test.specific", locale, null));
@@ -190,7 +190,7 @@
"[en_US] SPECIFIC",
resources.getString("test.specific", locale, null));
- locale = new Locale("fr");
+ locale = new Locale("fr","");
assertEquals("fr specific value",
"[fr] SPECIFIC",
resources.getString("test.specific", locale, null));
Index: src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java
===================================================================
RCS file:
/home/cvs/jakarta-commons-sandbox/resources/src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java,v
retrieving revision 1.3
diff -u -r1.3 ResourcesBaseTestCase.java
--- src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java 5 Jan
2003 03:29:58 -0000 1.3
+++ src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java 10 Jan
+2003 03:25:47 -0000
@@ -148,7 +148,7 @@
// Test retrieving missing resource keys
public void testMissing() throws Exception {
- Locale locale = new Locale("en");
+ Locale locale = new Locale("en","");
try {
resources.setReturnNull(false);
String value = resources.getString("test.missing", locale, null);
@@ -193,7 +193,7 @@
Locale locale = null;
- locale = new Locale("en");
+ locale = new Locale("en","");
assertEquals("en specific value",
"[test] SPECIFIC",
resources.getString("test.specific", locale, null));
@@ -203,7 +203,7 @@
"[test] SPECIFIC",
resources.getString("test.specific", locale, null));
- locale = new Locale("fr");
+ locale = new Locale("fr","");
assertEquals("fr specific value",
"[test] SPECIFIC",
resources.getString("test.specific", locale, null));
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
