Howdy, I've found it very useful to reuse some of the functionality in various implementations of FileName outside of VFS. To do so with local files, I found it necessary to expose LocalFileName and some of it's associates with a public modifier. It wasn't necessary for GenericFileName, it's already public. Is there any chance of this change making into the VFS? The changes are below for more info:
Index: src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java =================================================================== RCS file: /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java,v retrieving revision 1.5 diff -u -r1.5 GenericFileNameParser.java --- src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java 12 Feb 2003 07:56:15 -0000 1.5 +++ src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java 31 Mar 2003 19:44:52 -0000 @@ -63,7 +63,7 @@ * @author <a href="mailto:[EMAIL PROTECTED]">Adam Murdoch</a> * @version $Revision: 1.3 $ $Date: 2002/07/05 04:08:18 $ */ -final class GenericFileNameParser +public final class GenericFileNameParser extends LocalFileNameParser { /** Index: src/java/org/apache/commons/vfs/provider/local/LocalFileName.java =================================================================== RCS file: /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/provider/local/LocalFileName.java,v retrieving revision 1.5 diff -u -r1.5 LocalFileName.java --- src/java/org/apache/commons/vfs/provider/local/LocalFileName.java 17 Feb 2003 09:22:15 -0000 1.5 +++ src/java/org/apache/commons/vfs/provider/local/LocalFileName.java 31 Mar 2003 19:44:52 -0000 @@ -66,14 +66,14 @@ * @author <a href="mailto:[EMAIL PROTECTED]">Adam Murdoch</a> * @version $Revision: 1.5 $ $Date: 2003/02/17 09:22:15 $ */ -class LocalFileName +public class LocalFileName extends AbstractFileName { private final String rootFile; - private LocalFileName( final String scheme, - final String rootFile, - final String path ) + protected LocalFileName( final String scheme, + final String rootFile, + final String path ) { super( scheme, path ); this.rootFile = rootFile; Index: src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java =================================================================== RCS file: /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java,v retrieving revision 1.8 diff -u -r1.8 LocalFileNameParser.java --- src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java 12 Feb 2003 07:56:15 -0000 1.8 +++ src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java 31 Mar 2003 19:44:52 -0000 @@ -64,7 +64,7 @@ * @author <a href="mailto:[EMAIL PROTECTED]">Adam Murdoch</a> * @version $Revision: 1.5 $ $Date: 2002/03/09 10:31:30 $ */ -abstract class LocalFileNameParser +public abstract class LocalFileNameParser { /** * Determines if a name is an absolute file name. Index: src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java =================================================================== RCS file: /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java,v retrieving revision 1.5 diff -u -r1.5 WindowsFileNameParser.java --- src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java 12 Feb 2003 07:56:15 -0000 1.5 +++ src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java 31 Mar 2003 19:44:52 -0000 @@ -63,7 +63,7 @@ * @author <a href="mailto:[EMAIL PROTECTED]">Adam Murdoch</a> * @version $Revision: 1.3 $ $Date: 2002/07/05 04:08:18 $ */ -final class WindowsFileNameParser +public final class WindowsFileNameParser extends LocalFileNameParser { /** --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
