On Tue, 2003-07-08 at 08:47, David Graham wrote: > > It does not seem overly complicated and the work is already done. Is > > there some bug that requires simplification of the design? > > Code rarely seems complicated to the original author and bugs are not the > only triggers for refactoring. That class is over 1700 lines long and is > fairly complex.
The version I am looking at is 1500 lines. Here is the breakdown: 150 lines preamble - license and class javadoc 610 lines properties (getters/setters) and associated javadoc 150 lines ObjectFactory implementation 40 lines serialization code which leaves about 550 lines of what i consider logic that might require some analysis. It really is not that much. Are there groups of functionality int there that could be > refactored into separate classes? The ObjectFactory implementation should be separated into its own class, but I just found it easier to implement ObjectFactory and Referenceable in the same class as they generally have to be modified together. The 40 lines of serializable code can be eliminated with a dependency on commons-lang or it can be moved to a different class, but its not that much savings. It could be possible to build a slightly less complicated version by not allowing specification of per user limits (such as max connections). But I'd still like to maintain a version that does allow it. john mcnally Maintaining a class that large is > difficult. > > David > > > __________________________________ > Do you Yahoo!? > SBC Yahoo! DSL - Now only $29.95 per month! > http://sbc.yahoo.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
