I would prefer to keep it the way it is. If someone needs to explicitly check for null, let them. I missed the discussion about why this change is needed ... from my point of view, it looks like change for change's sake.
-- Howard M. Lewis Ship Creator, Tapestry: Java Web Components http://jakarta.apache.org/tapestry > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > Sent: Friday, July 18, 2003 12:15 PM > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: [lang] StringUtils isEmpty change > > > Howard, Henning, Others, > > Can you confirm or deny if the method isEmptyOrNull() is an > acceptably named replacement to isEmpty()? We are trying to > be more explicit in naming. > > Otherwise can you find a word that means 'empty or null'? > Perhaps we could have isBlank() as a synonym of isEmptyOrNull? > > Also, I should point out that the code you replaced in > turbine (see below) is not identical to that in > isEmpty()...which is part of the issue here. > > I also now think that deprecation may be necessary here. > > Stephen > > > > from: "Henning P. Schmiedehausen" <[EMAIL PROTECTED]> > > "Howard M. Lewis Ship" <[EMAIL PROTECTED]> writes: > > > > >I must have missed this. What change to StringUtils.isEmpty() are > > >you making. I like it just the way it it ... I had an identical > > >method in Tapestry that I deprecated and pointed at > StringUtils. I'm > > >very much reliant on "" == null. > > > > I strongly agree here! We replaced lots and lots of > > > > if ((foo == null) || foo.equals("")) with StringUtils.isEmpty() > > > > if ((foo != null) && !foo.equals("")) with StringUtils.isNotEmpty() > > > > in Turbine. If you change this behaviour, we would get > _very_ upset... > > :-) > > > > Regards > > Henning > > > > -- > > Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH > > [EMAIL PROTECTED] 49 9131 50 654 0 http://www.intermeta.de/ > > > > Java, perl, Solaris, Linux, xSP Consulting, Web Services > > freelance consultant -- Jakarta Turbine Development -- > hero for hire > > > > --- Quote of the week: "It is pointless to tell people > anything when > > you know that they won't process the message." --- Jonathan Revusky > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
