These should all be null in null out and documented as such (see StringUtils).
PS. make sure you change the version in the math subpackage, not the one in the main lang package! Stephen ----- Original Message ----- From: "Phil Steitz" <[EMAIL PROTECTED]> To: "Jakarta Commons Developers List" <[EMAIL PROTECTED]> Sent: Sunday, July 20, 2003 12:26 AM Subject: [lang] NumberUtils null handling > I have been going through NumberUtils code and tests to make sure that > handling of nulls is documented (and tested) correctly. I notice that > createNumber returns null for null (need to add a javadoc comment for > this); whereas createFloat, et al will throw NPEs on null. Shouldn't > these behave the same? In any case, the behavior should be documented. > > Should I submit a patch to > > 1. Make createFloat et al return null for null as createNumber does > > 2. Make no changes to NumberUtils methods, just add javadoc and tests > documenting current behavior. > > 3. Go back to sleep...;-) > > > Phil > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
