Hello,

I've taken the liberty to organize the [modeler] imports. 

FYI, I did not apply the patch but simply used Eclipse's Organize Imports
feature.

Also, FYI, here are the other compiler warnings noted by Eclispe:

Severity        Description     Resource        In Folder       Location
Creation Time
        Read access to enclosing field DomUtil.log is emulated by a
synthetic accessor method. Increasing its visibility will improve your
performance     DomUtil.java    Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/util        line 252
July 20, 2003 12:27:46 AM
        Read access to enclosing field DomUtil.log is emulated by a
synthetic accessor method. Increasing its visibility will improve your
performance     DomUtil.java    Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/util        line 253
July 20, 2003 12:27:46 AM
        Superfluous semicolon   BaseModelMBean.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 321        July
20, 2003 12:35:28 AM
        Superfluous semicolon   BaseModelMBean.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 391        July
20, 2003 12:35:28 AM
        Superfluous semicolon   BaseModelMBean.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 392        July
20, 2003 12:35:28 AM
        Superfluous semicolon   BaseModelMBean.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 479        July
20, 2003 12:35:28 AM
        Superfluous semicolon   BaseModelMBean.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 648        July
20, 2003 12:35:28 AM
        Superfluous semicolon   BaseModelMBean.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 733        July
20, 2003 12:35:28 AM
        Superfluous semicolon   ManagedBean.java        Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 522        July
20, 2003 12:35:28 AM
        The field AttributeInfo.serialVersionUID is hiding a field from type
FeatureInfo     AttributeInfo.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 84 July 20,
2003 12:35:28 AM
        The field ConstructorInfo.serialVersionUID is hiding a field from
type FeatureInfo        ConstructorInfo.java    Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 84 July 20,
2003 12:35:28 AM
        The field JndiJmx.attributes is hiding a field from type
BaseModelMBean  JndiJmx.java    Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 160        July
20, 2003 12:27:00 AM
        The field MbeansDescriptorsDigesterSource.location is hiding a field
from type ModelerSource MbeansDescriptorsDigesterSource.java    Apache
Jakarta Commons/modeler/src/java/org/apache/commons/modeler/modules     line
79      July 20, 2003 12:27:46 AM
        The field MbeansDescriptorsDigesterSource.source is hiding a field
from type ModelerSource MbeansDescriptorsDigesterSource.java    Apache
Jakarta Commons/modeler/src/java/org/apache/commons/modeler/modules     line
81      July 20, 2003 12:27:46 AM
        The field MbeansDescriptorsDOMSource.location is hiding a field from
type ModelerSource      MbeansDescriptorsDOMSource.java Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 87 July
20, 2003 12:27:46 AM
        The field MbeansDescriptorsDOMSource.source is hiding a field from
type ModelerSource      MbeansDescriptorsDOMSource.java Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 89 July
20, 2003 12:27:46 AM
        The field MbeansDescriptorsDynamicMBeanSource.location is hiding a
field from type ModelerSource   MbeansDescriptorsDynamicMBeanSource.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler/modules
line 35 July 20, 2003 12:27:46 AM
        The field MbeansDescriptorsDynamicMBeanSource.source is hiding a
field from type ModelerSource   MbeansDescriptorsDynamicMBeanSource.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler/modules
line 37 July 20, 2003 12:27:46 AM
        The field MbeansDescriptorsIntrospectionSource.location is hiding a
field from type ModelerSource   MbeansDescriptorsIntrospectionSource.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler/modules
line 26 July 20, 2003 12:27:46 AM
        The field MbeansDescriptorsIntrospectionSource.source is hiding a
field from type ModelerSource   MbeansDescriptorsIntrospectionSource.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler/modules
line 28 July 20, 2003 12:27:46 AM
        The field MbeansDescriptorsSerSource.location is hiding a field from
type ModelerSource      MbeansDescriptorsSerSource.java Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 19 July
20, 2003 12:27:46 AM
        The field MbeansDescriptorsSerSource.source is hiding a field from
type ModelerSource      MbeansDescriptorsSerSource.java Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 21 July
20, 2003 12:27:46 AM
        The field NotificationInfo.serialVersionUID is hiding a field from
type FeatureInfo        NotificationInfo.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 83 July 20,
2003 12:35:28 AM
        The field OperationInfo.serialVersionUID is hiding a field from type
FeatureInfo     OperationInfo.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 84 July 20,
2003 12:35:28 AM
        The field ParameterInfo.serialVersionUID is hiding a field from type
FeatureInfo     ParameterInfo.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 82 July 20,
2003 12:35:28 AM
        The local variable mname is never read  JndiJmx.java    Apache
Jakarta Commons/modeler/src/java/org/apache/commons/modeler     line 205
July 20, 2003 12:27:00 AM
        The local variable response is never read       BaseModelMBean.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler      line
723     July 20, 2003 12:35:28 AM
        The local variable result is never read BaseModelMBean.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler      line
668     July 20, 2003 12:35:28 AM
        The local variable setPropertyMethod is never read
IntrospectionUtils.java Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/util        line 468
July 20, 2003 12:27:46 AM
        The local variable stask is never read  ServiceTask.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler/ant  line
110     July 20, 2003 12:27:46 AM
        The local variable token is never read  IntrospectionUtils.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler/util line
671     July 20, 2003 12:27:46 AM
        The local variable type is never read   MbeansSource.java
Apache Jakarta Commons/modeler/src/java/org/apache/commons/modeler/modules
line 344        July 20, 2003 12:27:46 AM
        The local variable type is never read   Registry.java   Apache
Jakarta Commons/modeler/src/java/org/apache/commons/modeler     line 618
July 20, 2003 12:27:01 AM
        The method getRegistry() from the type Registry is deprecated
BaseModelMBean.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 1355       July
20, 2003 12:35:28 AM
        The method getRegistry() from the type Registry is deprecated
BaseNotificationBroadcaster.java        Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 272        July
20, 2003 12:35:28 AM
        The method getRegistry() from the type Registry is deprecated
JmxSet.java     Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/ant line 127        July
20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
JndiJmx.java    Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 260        July
20, 2003 12:27:00 AM
        The method getRegistry() from the type Registry is deprecated
Main.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 111        July
20, 2003 12:35:28 AM
        The method getRegistry() from the type Registry is deprecated
MbeansDescriptorsDigesterSource.java    Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 117
July 20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
MbeansDescriptorsDOMSource.java Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 125
July 20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
MbeansDescriptorsDynamicMBeanSource.java        Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 73 July
20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
MbeansDescriptorsIntrospectionSource.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 64 July
20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
MbeansDescriptorsSerSource.java Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 57 July
20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
MbeansSource.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 113
July 20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
MbeansSource.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 127
July 20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
RegistryTask.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/ant line 124        July
20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
RegistryTask.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/ant line 129        July
20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
ServiceTask.java        Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/ant line 107        July
20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
SimpleRemoteConnector.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/mbeans      line 213
July 20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
SimpleRemoteConnector.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/mbeans      line 224
July 20, 2003 12:27:46 AM
        The method getRegistry() from the type Registry is deprecated
SimpleRemoteConnector.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/mbeans      line 287
July 20, 2003 12:27:46 AM
        The method getServer() from the type Registry is deprecated
MbeansSource.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/modules     line 150
July 20, 2003 12:27:46 AM
        The method loadDescriptors(String, Object, String) from the type
Registry is deprecated  RegistryTask.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/ant line 124        July
20, 2003 12:27:46 AM
        The private constructor BaseNotification(String, Object, long, long,
int) is never used locally      BaseNotification.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 82 July 18,
2003 8:21:34 PM
        The private field BaseNotification.seq is never read locally
BaseNotification.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 76 July 18,
2003 8:21:34 PM
        The private field BaseNotification.source is never read locally
BaseNotification.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 75 July 18,
2003 8:21:34 PM
        The private field BaseNotification.tstamp is never read locally
BaseNotification.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 77 July 18,
2003 8:21:34 PM
        The private field BaseNotification.type is never read locally
BaseNotification.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 74 July 18,
2003 8:21:34 PM
        The private field ModelerTask.log is never read locally
ModelerTask.java        Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/ant line 69 July 20,
2003 12:27:46 AM
        The private field Registry.key is never read locally
Registry.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 161        July
20, 2003 12:27:01 AM
        The private field RegistryTask.log is never read locally
RegistryTask.java       Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler/ant line 81 July 20,
2003 12:27:46 AM
        The private method registerNotifications(FixedNotificationFilter)
from the type BaseNotificationBroadcaster is never used locally
BaseNotificationBroadcaster.java        Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 270        July
20, 2003 12:35:28 AM
        The static field MBeanOperationInfo.ACTION_INFO should be accessed
directly        OperationInfo.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 256        July
20, 2003 12:35:28 AM
        The static field MBeanOperationInfo.ACTION should be accessed
directly        OperationInfo.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 254        July
20, 2003 12:35:28 AM
        The static field MBeanOperationInfo.INFO should be accessed directly
OperationInfo.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 258        July
20, 2003 12:35:28 AM
        The static field MBeanOperationInfo.UNKNOWN should be accessed
directly        OperationInfo.java      Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 252        July
20, 2003 12:35:28 AM
        The static method setServer(MBeanServer) from the type Registry
should be accessed in a static way      Registry.java   Apache Jakarta
Commons/modeler/src/java/org/apache/commons/modeler     line 551        July
20, 2003 12:27:01 AM

-----Original Message-----
From: Davanum Srinivas [mailto:[EMAIL PROTECTED] 
Sent: Saturday, July 19, 2003 19:09
To: [EMAIL PROTECTED]
Subject: [modeler] cleanup imports

Can someone please apply this patch to fix imports in modeler? See attached
diff.txt

Thanks,
dims

=====
Davanum Srinivas - http://webservices.apache.org/~dims/

__________________________________
Do you Yahoo!?
SBC Yahoo! DSL - Now only $29.95 per month!
http://sbc.yahoo.com

Reply via email to