I am always for choosing better names. >- overlayString - shouldn't have 'String' in name. Better named as 'replace'
+1 >- concatenate - does the name as join(array, null) so should be called join(array) I cannot say I am fond of the whole 'join' terminology. It seems to math-like for String objects (as opposed to Sets). Since strings are 'added' together with '+', has 'add' been proposed? Not a great choice I know. +0 >- getNestedString - poor name, again with String in it. 'Nested' seems wrong to me. This is just a 'substring'-type of operation, how about 'substringBetween'? We already have 'substringAfter' and 'substringBefore', so this seems to fit just, well, just between. ;-) Gary -----Original Message----- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Thursday, July 31, 2003 17:12 To: Jakarta Commons Developers List Subject: [lang] StringUtils overlay/concatenate/getNested One final pass through StringUtils suggests these method names as dubious - overlayString - shouldn't have 'String' in name. Better named as 'replace' - concatenate - does the name as join(array, null) so should be called join(array) - getNestedString - poor name, again with String in it. Any views on changing these names (by deprecation of course) Stephen --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
