DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23593>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23593 Add Digest facade around java.security.MessageDigest ------- Additional Comments From [EMAIL PROTECTED] 2003-10-13 20:44 ------- Great, thanks for committing it. Three minor comments. First, we may as well make getMd5Digest() and getShaDigest() public. I can see using them outside of this class. The second comment is in regards to throwing InternalError. This exception is meant for internal JVM faults, which this is not. Perhaps an IllegalArgumentException is more acurate? Finally, the exception context is lost becuase exception chaining is not used. If codec doesn't already use commons-lang, than there's not much that can be done, I suppose. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
