In this case you would save the cost of concatenating the Strings and the descriptor.toString() operation. You need to figure out if that is a big cost where the code is going to be used.
Log4J has a faq entry that discusses this subject: http://jakarta.apache.org/log4j/docs/FAQ.html#fastLogging Steve > -----Original Message----- > From: David Graham [mailto:[EMAIL PROTECTED] > Sent: October 30, 2003 2:40 PM > To: Jakarta Commons Developers List > Subject: Re: [logging] logic for determing log level > > > > --- __matthewHawthorne <[EMAIL PROTECTED]> wrote: > > This is a general use question about [logging]. I'm > looking through the > > > > source for [betwixt], and I see lines like the following: > > > > if ( log.isTraceEnabled() ) { > > log.trace( "Is " + descriptor + " empty?" ); > > } > > > > What is the purpose of doing this check? If trace *is* > enabled, then > > isn't the same check done inside of the underlying logging > > implementation? > > Yes, this code is doing the check twice. > > > > > Is this some type of trick to improve performance? I'm probably > > misunderstanding it, but I just think that it adds clutter. > > This is an attempt to optimize the logging but I would be > *very* surprised > if it actually acheived any noticable performance benefits in > most cases. > Much Jakarta code I've seen uses the if checks on logging > calls except in > catch blocks. If you're in the catch block, you've already > incurred the > cost of the exception mechanism so optimizing the logging doesn't make > much sense. > > In my own code, I never use the if check because of the clutter. > > David > > > > > Any insights? > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > __________________________________ > Do you Yahoo!? > Exclusive Video Premiere - Britney Spears > http://launch.yahoo.com/promos/britneyspears/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
