In message <[EMAIL PROTECTED]>, steve cohen writes:
>Almost right, Daniel. I think it filters out dupes when versioning is turned
>on.
I thought that's what you said before, but I saw
if (versioning) {
files = super.parseFileList(listingStream);
} else {
in VMSFTPEntryParser.parseFileList. Is that an error? Should it
be if (!versioning) or do I have the meaning of the versioning
variable mixed up? Just wondering if we found a bug.
>Actually, I like your suggestion. The iterator seems the right place to do
>it.
As you know by now from my subsequent email, I have yet another suggestion :)
>Here's another problem, though, in our system. How do you turn versioning on
>in the auto-detect scenario? There's no hook in listFiles() for doing so.
I would say that's where the FTPFileEntryParserFactory comes in. If
someone wants VMSFTPEntryParsers with versioning turned on, they
can implement a factory that returns them. We could add a
setVMSVersioning(boolean) method to DefaultFTPFileEntryParserFactory
and save users the trouble. They'd have to do the following:
FTPClient ftp = new FTPClient();
DefaultFTPFileEntryParserFactory factory =
new DefaultFTPFileEntryParserFactory();
factory.setVMSVersioning(true);
ftp.setParserFactory(factory);
Does that sound acceptable or is there a better way?
daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
