Great!!!!
Good news, my change is already implemented as a new log4j bridge (the existing log4j bridge is final so I couldn't extend it). So that part is already done. In essence I copied the original bridge, factory and logger, into Log4jTraceFactory and Log4jTraceLogger. Then made minor changes for trace support.
cool.
if you do want to contribute new source files, please make sure that the ASF license is at the top of each. (it assigns the copyright to the ASF.)
I don't like the names so if you have better ones please share. Does anyone else find that happens to them. I.e. taking longer to find a good name than it does to actually write the code?
i'm not good at names but i usually find that it's easier to find out what the names should have been after the work has been completed and then refactor.
I am more than happy to cut my teeth on test cases and documentation. I know what you mean about documentation and test cases taking as much if not more time. In this case much more since the code only took 30 minutes to write.
As for the test cases. 95% of my test case can be accomplished by copying the log4j test case (with some mods of course) and adding some tests for the different things you can do to set the Trace level. Does this sound reasonable?
the code plus test cases and documentation would be great. i have a noted tendency to sit on code patches which arrive without test cases and documentation (so i thought that it'd only be fair to warn you first...)
As for docs I don't see anything in the commons-logging source I have. I have found this http://jakarta.apache.org/commons/logging/userguide.html but can't see where that is stored/ersioned. Is that where docs are needed? Perhaps a faq entry "How can I get tae support for log4j?" or when you say docs are you just referring to good javadocs?
any and all documentation is valuable. i try to ensure that i create javadocs and documentation for features i add but it does take time.
the userguide is currently just stored in cvs.
- robert
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
