I'll write up a little test over the weekend if not sooner. > There are lots of good changes that don't add any functional improvement > at the machine level, but a more OO solution may very well improve > things at the maintenance and class heirarchy level.
This is what I am striving for. Gary > -----Original Message----- > From: matthew.hawthorne [mailto:[EMAIL PROTECTED] > Sent: Thursday, March 11, 2004 13:56 > To: Jakarta Commons Developers List > Subject: Re: [lang] CharUtils.isAscii methods and CharSet, two issues > > Todd V. Jonker wrote: > > As is stands, isAsciiAlphaUpper follows > > DoTheSimplestThingThatCouldPossiblyWork but (perhaps) breaks > > OnceAndOnlyOnce. > > > > Still, I think the existing code is better. Such things tend to be > > called inside tight inner loops, and as such every bytecode counts. > Your > > suggested rewrite adds no functional improvement while increasing the > > execution time manyfold. I strongly suggest leaving it as-is. > > > I think that running some performance tests would provide the best > insight into possible effects on execution time. Gary, maybe you could > write a small test to see if this change truly would cause a performance > problem? > > There are lots of good changes that don't add any functional improvement > at the machine level, but a more OO solution may very well improve > things at the maintenance and class heirarchy level. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
