roxspring 2004/04/19 14:35:11
Modified: cli/src/java/org/apache/commons/cli2/option Tag:
RESEARCH_CLI_2_ROXSPRING GroupImpl.java
Added: cli/src/test/org/apache/commons/cli2/bug Tag:
RESEARCH_CLI_2_ROXSPRING Bug28005Test.java
Log:
Identified and removed infinite loop condition when processing anonymous arguments
PR:28005
Revision Changes Path
No revision
No revision
1.1.2.3 +6 -0
jakarta-commons/cli/src/java/org/apache/commons/cli2/option/Attic/GroupImpl.java
Index: GroupImpl.java
===================================================================
RCS file:
/home/cvs/jakarta-commons/cli/src/java/org/apache/commons/cli2/option/Attic/GroupImpl.java,v
retrieving revision 1.1.2.2
retrieving revision 1.1.2.3
diff -u -r1.1.2.2 -r1.1.2.3
--- GroupImpl.java 14 Apr 2004 18:31:16 -0000 1.1.2.2
+++ GroupImpl.java 19 Apr 2004 21:35:10 -0000 1.1.2.3
@@ -193,6 +193,12 @@
// move iterator back, current value not used
arguments.previous();
+ // if there are no anonymous arguments then this group can't
+ // process the argument
+ if(anonymous.isEmpty()){
+ break;
+ }
+
// TODO: why do we iterate over all anonymous arguments?
// canProcess will always return true?
for (final Iterator i = anonymous.iterator(); i.hasNext();) {
No revision
No revision
1.1.2.1 +79 -0
jakarta-commons/cli/src/test/org/apache/commons/cli2/bug/Attic/Bug28005Test.java
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
