DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29772>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29772

[beanutils]DateLocaleConverter does NOT return a default value if a conversion error 
occurs





------- Additional Comments From [EMAIL PROTECTED]  2004-07-09 05:13 -------
I'm attaching a patch for review which resolves the differences between JDK 1.3 
and JDK 1.4.

The patch converts any "localized date pattern" into the default date pattern 
characters - I added a new method to convert a pattern in ConvertUtils and 
changed DateLocaleConverter to use it in the parse() method.

The existing version uses a default pattern of SHORT date and SHORT time 
(i.e. 'MM/dd/yy HH:mm a' for Locale.US) if no pattern was specified - this 
seems wrong to me and I've changed the default to SHORT date (i.e. 'MM/dd/yy' 
for Locale.US) which seems more sensible.

I have also added more tests to the DateLocaleConverterTestCase - because of 
problems with DateFormatSymbols not beeing set in JDK 1.4, it some tests are 
skipped if the apprpriate Locale is not properly set up.

As far as the original issue with this bug - I think it was already resolved. 
Currently DateLocaleConverter does return the default value if there is a 
ConversionException. In the event of no default value being specified it throws 
the ConversionException.

Does anyone object to me applying this patch?

Niall

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to