olegk 2004/07/19 13:06:26
Modified: httpclient/src/java/org/apache/commons/httpclient Tag:
HTTPCLIENT_2_0_BRANCH HttpConnection.java
Log:
PR #29897 (questionable default value for BufferedOutputStream size in
HttpConnection)
Changelog:
BufferedOutputStream buffer size is 2k max
Contributed by Oleg Kalnichevski
Reviewed by Michael Becke
Revision Changes Path
No revision
No revision
1.67.2.12 +14 -6
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java
Index: HttpConnection.java
===================================================================
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java,v
retrieving revision 1.67.2.11
retrieving revision 1.67.2.12
diff -u -r1.67.2.11 -r1.67.2.12
--- HttpConnection.java 25 Jun 2004 03:27:40 -0000 1.67.2.11
+++ HttpConnection.java 19 Jul 2004 20:06:26 -0000 1.67.2.12
@@ -682,10 +682,14 @@
if (sendBufferSize != -1) {
socket.setSendBufferSize(sendBufferSize);
}
+ int outbuffersize = socket.getSendBufferSize();
+ if (outbuffersize > 2048) {
+ outbuffersize = 2048;
+ }
inputStream = new PushbackInputStream(socket.getInputStream());
outputStream = new BufferedOutputStream(
new WrappedOutputStream(socket.getOutputStream()),
- socket.getSendBufferSize()
+ outbuffersize
);
isOpen = true;
used = false;
@@ -735,10 +739,14 @@
if (sendBufferSize != -1) {
socket.setSendBufferSize(sendBufferSize);
}
+ int outbuffersize = socket.getSendBufferSize();
+ if (outbuffersize > 2048) {
+ outbuffersize = 2048;
+ }
inputStream = new PushbackInputStream(socket.getInputStream());
outputStream = new BufferedOutputStream(
new WrappedOutputStream(socket.getOutputStream()),
- socket.getSendBufferSize()
+ outbuffersize
);
usingSecureSocket = true;
tunnelEstablished = true;
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
