Hi,

I am using MultipartStream.java to parse a special multipart message. That message does not conform well enough to the standards, i.e., instead of using \r\n to be the separator, it uses just \n.

So, I have to modify MultipartStream to adapt to my use.

During the modification, I found out that the length for various separators are hardcoded. For example, in readHeaders() method, there is
while (i < 4)
{
...
}


But, it would be better to have
while (i < HEADER_SEPARATOR.length)
{
...
}

I know that the hardcoding works because the header separator never change because of the multipart RFC. But, it is a good engineering practice to not hard code this.

Thanks for your consideration,

Jian

_________________________________________________________________
Planning a family vacation? Check out the MSN Family Travel guide! http://dollar.msn.com



--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to