The following comment has been added to this issue:
Author: Scott Howlett
Created: Thu, 26 Aug 2004 10:44 PM
Body:
A minor nit perhaps, but if variables.get(name) returns non-null, then I don't think
you need to check again to see if the variable was defined. The definedHere line could
be changed to something like:
boolean definedHere = result != null || variables.containsKey(name);
for a little performance improvement.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-78?page=comments#action_37518
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-78
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-78
Summary: Null variables are passed over by scope inheritance
Type: Bug
Status: Open
Priority: Minor
Project: jelly
Components:
core / taglib.core
Fix Fors:
1.0-beta-4
Assignee: dion gillard
Reporter: Scott Howlett
Created: Tue, 26 Aug 2003 2:08 PM
Updated: Thu, 26 Aug 2004 10:44 PM
Description:
If I explicitly assign variable foo a null value in the current scope but it has a
value in some parent scope, findVariable() will bypass the null value in favor of the
non-null value up the chain.
This is because JellyContext.getVariable & findVariable just test the result of
variables.get(name) against null instead of also checking with containsKey like this:
Object value = variables.get(name);
if ( value == null
&& !variables.containsKey(name)
&& isInherit() ) {
....
Perhaps this is an explicit design decision, but I thought it was worth mentioning.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
