dgraham 2004/09/03 06:04:32
Modified: dbutils/src/java/org/apache/commons/dbutils DbUtils.java
Log:
Added a try/finally block in commitAndClose() to ensure the connection is always
closed.
Revision Changes Path
1.6 +6 -3
jakarta-commons/dbutils/src/java/org/apache/commons/dbutils/DbUtils.java
Index: DbUtils.java
===================================================================
RCS file:
/home/cvs/jakarta-commons/dbutils/src/java/org/apache/commons/dbutils/DbUtils.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- DbUtils.java 3 Sep 2004 13:01:58 -0000 1.5
+++ DbUtils.java 3 Sep 2004 13:04:32 -0000 1.6
@@ -60,7 +60,7 @@
public static void closeQuietly(Connection conn) {
try {
close(conn);
- } catch (SQLException sqle) {
+ } catch (SQLException e) {
// quiet
}
}
@@ -107,8 +107,11 @@
*/
public static void commitAndClose(Connection conn) throws SQLException {
if (conn != null) {
- conn.commit();
- conn.close();
+ try {
+ conn.commit();
+ } finally {
+ conn.close();
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
