I don't have a vote, but, if I did, I would vote very high in favor of all such decisions. Hard coding is not good for lots of reasons, in my opinion. If the -1s mean the same thing "all over the place", then they should be identified as to what they mean in all places with the value put in one place. In my opinion, this is one of the more valuable knee jerks we should have.

Michael McGrady

Gary Gregory wrote:

Speaking of "-1"s. I wonder if we should create a constant for the "-1
means NOT_FOUND" concept. This value is hard coded all over the place in
ArrayUtils. It seems to me like it would make the code more readable.

Gary



-----Original Message-----
From: Stephen Colebourne [mailto:[EMAIL PROTECTED]
Sent: Saturday, October 09, 2004 04:27
To: Jakarta Commons Developers List
Subject: [lang] ArrayUtils.lastIndex

ArrayUtils.lastIndex
This method is effectively:
 array.length - 1
with null checks

This method was added in the 1.41 version of ArrayUtils. I want to


remove


it, as it really doesn't seem to add any value over and above


getLength().


The original bug request didn't ask for it either:
http://issues.apache.org/bugzilla/show_bug.cgi?id=26594

I intend to remove the method unless I hear objections.

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]









--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to