On Tue, 30 Nov 2004 10:00:07 -0800, Martin Cooper <[EMAIL PROTECTED]> wrote: > On Tue, 30 Nov 2004 00:06:52 -0800, Craig McClanahan <[EMAIL PROTECTED]> > wrote: > > -1 > > > > Besides the fact that this change bundle breaks the "ant clean dist" > > command that is necessary for the current ngihtly build scripts to > > work > > I don't believe that's why the build broke. The problem is that, for > some reason, the JSF jar files have disappeared from ibiblio. I don't > know how to fix that. >
Between us dual tracking (trying to get MyFaces up on ibiblio and a solution to how build.xml files are generated) we should be able to make progress on this. On the other hand, we could also revert to the build.xml before the one generated by Maven was checked in. > >, it alters the semantics with changes like this: > > How does it change the semantics? All of 'public', 'static' and > 'final' are redundant here, because this is an interface. True ... i've been tending to use abstract classes rather than interfaces, to minimize the impact of future changes on backwards compatibility. Change my -1 to -0 ... the visual impact of seeing "public static final" on a String constant in an interface is still going to tell the developer looking at this file something about the intent that this be a manifest constant, regardless of whether it is technically redudant or not. Craig > > -- > Martin Cooper > > > > > > > > > > > Index: Catalog.java > > > =================================================================== > > > RCS file: > > > /home/cvs/jakarta-commons/chain/src/java/org/apache/commons/chain/Catalog.java,v > > > retrieving revision 1.6 > > > retrieving revision 1.7 > > > diff -u -r1.6 -r1.7 > > > --- Catalog.java 25 Feb 2004 00:01:07 -0000 1.6 > > > +++ Catalog.java 30 Nov 2004 05:52:22 -0000 1.7 > > > @@ -37,7 +37,7 @@ > > > * <p>A default context attribute for storing a default [EMAIL > > > PROTECTED] Catalog}, > > > * provided as a convenience only.</p> > > > */ > > > - public static final String CATALOG_KEY = > > > "org.apache.commons.chain.CATALOG"; > > > + String CATALOG_KEY = "org.apache.commons.chain.CATALOG"; > > > > > > /** > > > > > > > Craig > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
